Replace "band limited" with "bandlimited" #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcunliffe
approved these changes
May 17, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## wgraham-217-CLI_to_input_file #299 +/- ##
==============================================================
- Coverage 48% 24% -23%
==============================================================
Files 65 64 -1
Lines 7792 3589 -4203
==============================================================
- Hits 3712 869 -2843
+ Misses 4080 2720 -1360
☔ View full report in Codecov by Sentry. |
willGraham01
force-pushed
the
replace-band-limited-with-bandlimited
branch
from
919cd9a
to
c3e0e7e
Compare
willGraham01
force-pushed
the
wgraham-217-CLI_to_input_file
branch
from
40df6da
to
5d30807
Compare
samcunliffe
added a commit
that referenced
this pull request
May 17, 2023
* Change flag names in the input files * Update matlab tests to use_pstd over usecd * Update MATLAB unit test data files * Allow python adjustment to point to correct variables * Remove unused variable and InterpMethod enum in Simulation_Parameters * Rename PreferredInterpolationMethods enum to InterpolationMethod, in line with SolverMethod * Create class to handle flag values from input file * Update enum definitions and rename variables * Enforce writing of flags as bools * pim -> interpolation_method everywhere * Unit tests no longer rely on default values to pass * Update README and remove ArgumentParser's old functionality * Remove unneccessary flags from config files * Remove CLI flag-add options from system tests (these are no longer used) * Fix rebase errors: - ArgumentNamespace was still checking for now-redundant flags - One of simulation_manager's implementation files was missing an include - Typo in docstring for Grid object * Fix self-imposed typos * Update Zenodo URLs to point to new data upload. * Apply suggestions from code review Co-authored-by: Sam Cunliffe <samcunliffe@users.noreply.github.com> * Revert lines in readme.md * Break out fetch_flag_value into a src file * _pim -> im * CTRL+H is good (#299) --------- Co-authored-by: Sam Cunliffe <samcunliffe@users.noreply.github.com>
This was referenced May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #298