Two more system tests.

[samcunliffe]

This PR is adds two more test cases provided by @prmunro (thanks!) and another 2/4 of #30: a test w/ exi present and a test w/ exdetintegral.

The first is very fast:

py.test tdms/tests/system/test_arc10.py  73.70s user 10.40s system 563% cpu 14.916 total

The second a little slower (but not the slowest):

py.test tdms/tests/system/test_arc09.py  704.33s user 40.89s system 681% cpu 1:49.37 total
py.test tdms/tests/system/test_arc03.py  1171.14s user 66.51s system 527% cpu 3:54.44 total

And notably I had to tweak the HDF5File class to cope with groups.

[t-young31]

apologies – don't really have time for a proper review today. but in general more tests = better so generally happy. only thought is to reduce the system size so we can be more comprehensive i.e. have both 3D and 2D examples, for instance(?)

[samcunliffe]

apologies – don't really have time for a proper review today. but in general more tests = better so generally happy. only thought is to reduce the system size so we can be more comprehensive i.e. have both 3D and 2D examples, for instance(?)

I like it. Although perhaps we merge this now (since slow protection >> no protection). And I'll ticket myself to speedup the rest of the tests.

[dstansby]

Putting each test in a new file is resulting in a lot of boilerplate code - it looks like you're running through the same steps each time, so I'd recommend writing one test function an parametrizing it. Something like:

@pytest.mark.parametrize('input_file, reference_file', [('arc_09/in/pstd_fs.mat', 'arc_09/out/pstd_fs.mat'), ...])
def test_tdms():
    ...

[t-young31]

Looks great to me – agree some slow protection is definitely better than no fast protection. However, I'd be inclined to make the tests fast ASAP, to limit the trees we're burning 🌲 🔥

[prmunro]

Hi All, I can further shorten the time for tests to complete without compromising the validity of the test. This would mean uploading new test files. Should I do this?

[samcunliffe]

Hi All, I can further shorten the time for tests to complete without compromising the validity of the test. This would mean uploading new test files. Should I do this?

Hey @prmunro ,
Yes, that would be very helpful indeed! We should be able to update the zenodo version and keep the same links and everything. So we potentially don't even need to PR.