New infra structure #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please go to package.json and change the FILL-IN-HERE placeholders. |
Liby99
requested changes
Oct 20, 2018
| @@ -11,6 +11,7 @@ import { Input, Button, Card, Row, Col, Icon } from 'react-materialize'; | |||
| import Header from './Header'; | |||
| import LeasingCard from './LeasingCard'; | |||
| import GoogleMapTest from './GoogleMapTest'; | |||
| import '~/components/styles/search-page.scss'; | |||
There was a problem hiding this comment.
If the style sheet is in the same directory, then use import ‘./styles/...’
| @@ -0,0 +1,60 @@ | |||
| /************** search page *************/ | |||
There was a problem hiding this comment.
You can remove the comments in these files now
source/react/src/styles/index.scss
Outdated
| @@ -0,0 +1,9 @@ | |||
| * { | |||
| font-family: "Microsoft JhengHei", sans-serif; | |||
There was a problem hiding this comment.
Make sure the indentation is 2 spaces
|
Thanks. Approved. |
|
I have fill in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New infra structure for the front-end. Now we have two ports. One for development and one for final publish. Details about how to run please see the readme of front-end.