Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACS year parameter made user-specified #45

Merged
merged 9 commits into from
May 3, 2018
Merged

Conversation

cvanoli
Copy link
Collaborator

@cvanoli cvanoli commented Apr 27, 2018

  • In the Starter object, I created a year variable which corresponds to the ACS year data for the 5-year estimates dataset. The default value is 2016 which is the latest dataset (2011-2016). The 'acsyear' parameter is saved as an object variable (self.acsyear). It is used in the block group and tract query functions.

  • Changed 'census.acs.get()' by 'census.acs5.get()' in the '_query' function. This specification is reccomended in the census package documentation. https://github.com/datamade/census/blob/master/census/core.py#L435-L438

  • Added parenthesis in a print function in the demo for it to be Python 3 compatible.

@coveralls
Copy link

coveralls commented Apr 30, 2018

Coverage Status

Coverage decreased (-1.3%) to 82.808% when pulling 26a0f79 on ASC-year-parameter into 7e8f470 on master.

Copy link
Contributor

@janowicz janowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I see that you added the acsyear parameter to starter2.py Could you please also make the change to starter.py?

@cvanoli cvanoli merged commit c3588e4 into master May 3, 2018
@cvanoli cvanoli deleted the ASC-year-parameter branch May 3, 2018 00:15
@cvanoli cvanoli restored the ASC-year-parameter branch May 3, 2018 00:15
@cvanoli cvanoli deleted the ASC-year-parameter branch September 10, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants