Skip to content

Conversation

maxreichmann
Copy link
Member

Since messageDetails without URLs may contain user input, they have to be encoded too.
Follow-up of discussion of #765.

JIRA: CPOUI5FOUNDATION-1061

@maxreichmann maxreichmann marked this pull request as draft July 14, 2025 10:56
@maxreichmann
Copy link
Member Author

Converted to draft for now, needs further refactoring regard. messageDetails with user input and URLs.

@coveralls
Copy link

coveralls commented Jul 14, 2025

Coverage Status

coverage: 86.615% (+0.009%) from 86.606%
when pulling f4b8948 on refactor-html-xss-escape-msgdetails
into 01c8197 on main.

@maxreichmann maxreichmann marked this pull request as ready for review July 14, 2025 14:55
@maxreichmann maxreichmann changed the title refactor(HTML XSS): Encode messageDetails without URLs too refactor(HTML XSS): Encode every part of messageDetails Jul 14, 2025
@maxreichmann maxreichmann requested review from RandomByte and a team July 14, 2025 14:58
Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RandomByte RandomByte changed the title refactor(HTML XSS): Encode every part of messageDetails refactor(HTML): Encode every part of messageDetails Jul 15, 2025
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maxreichmann maxreichmann merged commit f54b79e into main Jul 15, 2025
19 checks passed
@maxreichmann maxreichmann deleted the refactor-html-xss-escape-msgdetails branch July 15, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants