fix(dts-generator): fix more derived type names for module:* classes #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akudev
reviewed
Oct 10, 2025
| fullEventTypealiasName, | ||
| shortEventTypealiasName, | ||
| } = makeEventParametersName(symbol.name, event.name); | ||
| const { eventParametersNames, eventTypeAliasNames } = |
There was a problem hiding this comment.
the plural forms are intentional? Seems so, but then again, the function returning the "...Names" is called "make...Name"
There was a problem hiding this comment.
Yes, they are intentional. The returned objects contain different "names". But I'm definitely open for better naming proposals.
akudev
reviewed
Oct 10, 2025
packages/dts-generator/src/utils/json-event-parameter-interfaces.ts
Outdated
Show resolved
Hide resolved
|
I think you anyway have to adapt the test snapshots. Maybe seeing the resulting changes will also help understanding the effects of this fix. |
When a managed object class has a module:* name, the names are now correctly split into prefix and base name when calculating the name of the EventParameters and EventType types. The implementation of the calculations is now shared with the calculation implemented in b6c0fe5.
codeworrior
force-pushed
the
support-module-names-for-events
branch
from
0ea9810 to
62213b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a managed object class has a module:* name, the names are now correctly split into prefix and base name when calculating the name of the EventParameters and EventType types.
The implementation of the calculations is now shared with the calculation implemented in b6c0fe5.