fix(ui5-shellbar): arrow key navigation inputs support #11684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobrinyonkov
changed the title
dobrinyonkov
force-pushed
the
shellbar-arrow-navigation
branch
from
02ecefa to
eca9e43
Compare
dobrinyonkov
changed the title
yanaminkova
approved these changes
Jun 13, 2025
|
🎉 This PR is included in version v2.12.0-rc.1 🎉 The release is available on v2.12.0-rc.1 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update improves keyboard navigation in the
ShellBarcomponent. It also cleans up parts of the code to make it easier to maintain.Keyboard Navigation
Arrow keys in input fields
Arrow keys now move focus only if the cursor is at the start or end of the input.
Test for input navigation
Added a Cypress test to check arrow key behavior in the search input.
Refactoring
Simplified focus logic
Replaced
_getVisibleAndInteractiveItemsand_getNavigableContentwithgetTabbableElements.Navigation helpers
Added
_allowChildNavigationand_allowInputNavigationto handle when child elements should manage keyboard events.