Skip to content

fix(ui5-combobox): prevent whitespace below value state when no items are present #12218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2025
Merged

fix(ui5-combobox): prevent whitespace below value state when no items are present #12218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions packages/main/cypress/specs/ComboBox.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,29 @@ describe("General Interaction", () => {
.find(".ui5-li-title")
.should("have.text", "I #1");
});

it("should not render ComboBox items list when no items are present", () => {
cy.mount(
<ComboBox valueState="Negative" open>
{/* No ComboBox items */}
</ComboBox>
);

cy.get("[ui5-combobox]")
.as("combo")
.shadow()
.find("ui5-responsive-popover")
.as("popover")
.should("have.attr", "open");

cy.get("@popover")
.find(".ui5-responsive-popover-header.ui5-valuestatemessage-root")
.should("exist");

cy.get("@popover")
.find("ui5-list")
.should("not.exist");
});
});

describe("Keyboard navigation", () => {
Expand Down
2 changes: 2 additions & 0 deletions packages/main/src/ComboBoxPopoverTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ export default function ComboBoxPopoverTemplate(this: ComboBox) {
</div>
}

{!!this._filteredItems.length &&
<List
class="ui5-combobox-items-list"
separators="None"
Expand All @@ -97,6 +98,7 @@ export default function ComboBoxPopoverTemplate(this: ComboBox) {
>
{ this._filteredItems.map(item => <slot name={item._individualSlot}></slot>)}
</List>
}

{this._isPhone &&
<div slot="footer" class="ui5-responsive-popover-footer">
Expand Down
Loading