Skip to content

fix(ui5-tabcontainer): correct focus handling in overflow modes #12259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2025
Merged

fix(ui5-tabcontainer): correct focus handling in overflow modes #12259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 96 additions & 0 deletions packages/main/cypress/specs/TabContainer.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1144,6 +1144,102 @@ describe("TabContainer keyboard handling", () => {
cy.get("@tabContainer").shadow().find("ui5-responsive-popover").as("popover");
cy.get("@popover").should("be.visible", "Popover is opened");
});

it("tests handling of the focus navigation with End overflow mode", () => {
cy.mount(
<>
<Button id="btn1"/>
<TabContainer id="tabContainerStartAndEndOverflow" overflowMode="End">
<Tab text="One">Tab 1</Tab>
<Tab text="Two">Tab 2</Tab>
<Tab id="activeTab" text="Three" selected>Tab 3</Tab>
<Tab text="Four">Tab 4</Tab>
<Tab text="Five">Tab 4</Tab>
</TabContainer>
<Button id="btn2"/>
</>
);

cy.viewport(300, 1080);

cy.get("#tabContainerStartAndEndOverflow").shadow().find(".ui5-tc__overflow--end").as("endOverflow");

cy.get("#btn1").realClick();

cy.realPress("Tab");

cy.realPress("ArrowRight");

cy.get("@endOverflow")
.find("[ui5-button]")
.shadow()
.find(".ui5-button-root")
.should("be.focus");

cy.realPress("Tab");

cy.get("#btn2").should("be.focused");

cy.realPress(["Shift", "Tab"]);

cy.get("@endOverflow")
.find("[ui5-button]")
.shadow()
.find(".ui5-button-root")
.should("be.focus");

cy.realPress(["Shift", "Tab"]);

cy.get("#btn1").should("be.focused");
});

it("tests handling of the focus navigation with Start overflow mode", () => {
cy.mount(
<>
<Button id="btn1"/>
<TabContainer id="tabContainerStartAndEndOverflow" overflowMode="StartAndEnd">
<Tab text="One">Tab 1</Tab>
<Tab text="Two">Tab 2</Tab>
<Tab id="activeTab" text="Three" selected>Tab 3</Tab>
<Tab text="Four">Tab 4</Tab>
<Tab text="Five">Tab 4</Tab>
</TabContainer>
<Button id="btn2"/>
</>
);

cy.viewport(300, 1080);

cy.get("#tabContainerStartAndEndOverflow").shadow().find(".ui5-tc__overflow--start").as("startOverflow");

cy.get("#btn1").realClick();

cy.realPress("Tab");

cy.realPress("ArrowLeft");

cy.get("@startOverflow")
.find("[ui5-button]")
.shadow()
.find(".ui5-button-root")
.should("be.focus");

cy.realPress("Tab");

cy.get("#btn2").should("be.focused");

cy.realPress(["Shift", "Tab"]);

cy.get("@startOverflow")
.find("[ui5-button]")
.shadow()
.find(".ui5-button-root")
.should("be.focus");

cy.realPress(["Shift", "Tab"]);

cy.get("#btn1").should("be.focused");
});
});

describe("TabContainer popover", () => {
Expand Down
2 changes: 0 additions & 2 deletions packages/main/src/TabContainerTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ export default function TabContainerTemplate(this: TabContainer, injectedPartial
<Button
endIcon={this.overflowMenuIcon}
data-ui5-stable="overflow-start"
tabindex={ -1 }
tooltip={this.overflowMenuTitle}
accessibilityAttributes={this.overflowBtnAccessibilityAttributes}
>
Expand Down Expand Up @@ -108,7 +107,6 @@ export default function TabContainerTemplate(this: TabContainer, injectedPartial
<Button
endIcon={this.overflowMenuIcon}
data-ui5-stable="overflow-end"
tabindex={ -1 }
tooltip={this.overflowMenuTitle}
accessibilityAttributes={this.overflowBtnAccessibilityAttributes}
>
Expand Down
Loading