Skip to content

fix(ui5-illustrated-message): fix imports filter #12271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
Merged

fix(ui5-illustrated-message): fix imports filter #12271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/tools/components-package/nps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const cypressEnvVariables = (options, predefinedVars) => {
let variables = [];
const { cypress_code_coverage, cypress_acc_tests } = options.internal ?? {};

// Handle environment variables like TEST_SUITE
// Handle environment variables like TEST_SUITE
if (predefinedVars) {
variables = [...predefinedVars];
}
Expand All @@ -36,7 +36,7 @@ const getScripts = (options) => {
const createIllustrationsJSImportsScript = illustrations.join(" && ");

// The script creates the "src/generated/js-imports/Illustration.js" file that registers loaders (dynamic JS imports) for each illustration
const createIllustrationsLoadersScript = illustrationsData.map(illustrations => `node ${LIB}/generate-js-imports/illustrations.js ${illustrations.destinationPath} ${illustrations.dynamicImports.outputFile} ${illustrations.set} ${illustrations.collection} ${illustrations.dynamicImports.location} ${illustrations.dynamicImports.filterOut.join(" ")}`).join(" && ");
const createIllustrationsLoadersScript = illustrationsData.map(illustrations => `node ${LIB}/generate-js-imports/illustrations.js ${illustrations.destinationPath} ${illustrations.dynamicImports.outputFile} ${illustrations.set} ${illustrations.collection} ${illustrations.dynamicImports.location} ${illustrations.dynamicImports.filterOut.join(",")}`).join(" && ");

const tsOption = !options.legacy || options.jsx;
const tsCommandOld = tsOption ? "tsc" : "";
Expand Down
2 changes: 1 addition & 1 deletion packages/tools/lib/generate-js-imports/illustrations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ const config = {
set: process.argv[4],
collection: process.argv[5],
location: process.argv[6],
filterOut: process.argv.slice[7],
filterOut: process.argv[7].slice().split(","),
};

// Run the generation process
Expand Down
Loading