feat(ui5-busyindicator): initial implementation #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #371 |
vladitasev
previously requested changes
May 21, 2019
packages/main/src/BusyIndicator.js
Outdated
| * @defaultvalue false | ||
| * @public | ||
| */ | ||
| invisible: { type: Boolean, defaultValue: false }, |
There was a problem hiding this comment.
Maybe call this "hide"? I guess it's the reverse of "visible" from openui5
There was a problem hiding this comment.
Another thought, can they easily use browser API for this? (display: none, etc...)
There was a problem hiding this comment.
I prefer to keep the property and rename it to hide because the usage in frameworks will be smoother
vladitasev
requested changes
May 29, 2019
ilhan007
reviewed
May 29, 2019
| @keyframes grow { | ||
| 0%, 50%, 100% { | ||
| -webkit-transform: scale( 1.0); | ||
| -moz-transform: scale( 1.0); |
There was a problem hiding this comment.
In the old days that was indeed necessarily, but could you check if all the browser prefixed properties are still needed (we do not support opera for sure)
ilhan007
reviewed
May 29, 2019
ilhan007
changed the title
ilhan007
reviewed
May 30, 2019
packages/main/test/sap/ui/webcomponents/main/pages/BusyIndicator.html
Outdated
Show resolved
Hide resolved
ilhan007
reviewed
May 30, 2019
packages/main/src/themes/sap_fiori_3/BusyIndicator-parameters.css
Outdated
Show resolved
Hide resolved
ilhan007
reviewed
May 30, 2019
vladitasev
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.