Skip to content

fix(f6-navigation): skip empty groups #6397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2023
Merged

fix(f6-navigation): skip empty groups #6397

merged 1 commit into from
Feb 6, 2023

Conversation

nnaydenow
Copy link
Contributor

@nnaydenow nnaydenow commented Feb 1, 2023 •
edited
Loading

Now, we skip groups that don't have focusable element inside them.

FIXES: #6387

@nnaydenow nnaydenow merged commit f49c593 into main Feb 6, 2023
@nnaydenow nnaydenow deleted the f6 branch February 6, 2023 11:06
kskondov pushed a commit that referenced this pull request Feb 10, 2023
@nnaydenow @kskondov
fix(f6-navigation): skip empty groups (#6397)
a81d1e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@vladitasev vladitasev Awaiting requested review from vladitasev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SF_ACC][1.9.0][F6Navigation] F6 navigation is stuck due to javascript error when there are blocks which has no focusable element
2 participants
@nnaydenow @ilhan007