chore: enable translations step #2 #715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
changed the title
ilhan007
changed the title
MapTo0
previously approved these changes
Aug 12, 2019
| @@ -1,5 +1,5 @@ | |||
| import { registerIcon } from "../SVGIconRegistry.js"; | |||
| import { ICON_MESSAGE_ERROR } from "../../../main/src/i18n/defaults.js"; | |||
| import { ICON_MESSAGE_ERROR } from "../../../main/dist/generated/i18n/i18n-defaults"; | |||
There was a problem hiding this comment.
shouldn't this be @ui5/webcomponents/dist/generaated/i18n/...?
There was a problem hiding this comment.
Added .js and leave it with relative path
pskelin
reviewed
Aug 12, 2019
packages/main/package.json
Outdated
| "copy:qunit": "cpx \"test/**/qunit/*.*\" dist/test-resources", | ||
| "copy:webcomponents-polyfill": "cpx \"../../node_modules/@webcomponents/webcomponentsjs/**/*.*\" dist/webcomponentsjs/", | ||
| "dev": "npm-run-all --parallel watch:templates watch:samples watch:pages watch:qunit watch:src watch:bundle watch:styles-bundles watch:styles-components copy:webcomponents-polyfill", | ||
| "dev": "npm-run-all --parallel watch:templates watch:samples watch:pages watch:qunit watch:src watch:bundle watch:styles-bundles watch:styles-components copy:webcomponents-polyfill build:i18n-defaults", |
There was a problem hiding this comment.
we should avoid race conditions and run the i18n sequentially as first step and the current parallel steps as a second step after the i18n is generated.
pskelin
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After introducing the
translation_v2.jsonandmessagebundle.properties(#Step1) to enable the translation team find and process our texts we continue improving our message translation setupdefaults.jsi18n-defaults.jsunderdist/generated/i18n/folder for eachmessagebundle_*.propertiesfilei18n-toJSONto convert the messagebundle_*.propertiesfiles to messagebundle_*.jsonones