fix[l-03]: check whitelist interface using erc165 #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
There was a problem hiding this comment.
Pull Request Overview
This PR implements interface validation using ERC165 for whitelist contracts to ensure type safety. The changes add ERC165 support to the whitelist interface hierarchy and validate that contracts implement the expected interface before assignment.
- Added ERC165 interface checking to validate whitelist contract compatibility
- Modified whitelist interfaces and implementations to inherit from IERC165 and support interface detection
- Updated validation logic to use ERC165Checker instead of simple zero address checks
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ManagedOptimisticOracleV2.sol | Added ERC165 interface validation for whitelist assignments and removed zero address checks for internal setters |
| AddressWhitelistInterface.sol | Extended interface to inherit from IERC165 for ERC165 support |
| DisableableAddressWhitelist.sol | Implemented supportsInterface method to support ERC165 interface detection |
| AddressWhitelist.sol | Added ERC165 inheritance and implemented supportsInterface method |
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
grasphoper
reviewed
Aug 1, 2025
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
md0x
reviewed
Aug 1, 2025
| // Zero address is allowed to disable the custom proposer whitelist. | ||
| if (whitelist != address(0)) { | ||
| require( | ||
| ERC165Checker.supportsInterface(whitelist, type(AddressWhitelistInterface).interfaceId), |
There was a problem hiding this comment.
nit: maybe this could go in a internal view function "_validateWhitelist" given that we check this in different places.
There was a problem hiding this comment.
indeed, great suggestion, added in 7bb517c
md0x
approved these changes
Aug 1, 2025
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged after #6 resolving for any conflicts and also adding
supportsInterfaceimplementation to the newDisabledAddressWhitelistcontract.