-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot import cbp-theme using Webpack #24
Labels
Comments
I'm going to take this one. |
Does this mean we can close this one since #23 is closed? |
I would like @apobbati to confirm this and then close it out. |
@apobbati can we verify this? |
tma001
added a commit
that referenced
this issue
Nov 28, 2016
-minify, remove comments from bundles -reorder script imports in example example kitchen sink app -added jQuery in 3rd party folder in example kitchen sink app -made jQuery external dependency in webpack (looks for global / script tag) -export cbp-theme.js as UMD module -remove jQuery from package.json dependencies (looking for it as global script var in browser now) see issues #24, #56, #59
davezen1
pushed a commit
that referenced
this issue
Nov 29, 2016
* fix: webpack build and ie11 issue -made jQuery external dependency in webpack (looks for global / script tag) -export cbp-theme.js as UMD module -added polyfill for ie11 object.asign (for input mask) See issues #24, #56 * no need to track generated files * fix: webpack build -minify, remove comments from bundles -reorder script imports in example example kitchen sink app -added jQuery in 3rd party folder in example kitchen sink app -made jQuery external dependency in webpack (looks for global / script tag) -export cbp-theme.js as UMD module -remove jQuery from package.json dependencies (looking for it as global script var in browser now) see issues #24, #56, #59 * removing jQuery export as we now look to reuse global jQuery from script tag for cbp-theme * Cleaned up, simplified, and separated README for consumers and developers. Also moved alternative installation methods (webjars/gradle) to separate file. See issue #57. * go back to tracking /app/kitchensink/dist for publishing purposes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To reproduce in a webpack project:
import 'cbp-theme'
This is the error I'm getting:
@d-amit I think the resolution to this issue is to include
jquery.inputmask.js
in the dist directory or re-work the bundling forjquery.inputmask.bundle.js
.#23 We can fix these issues by moving to Webpack and let it handle the dependency order and inclusion.
The text was updated successfully, but these errors were encountered: