fix: webpack build and ie11 issue #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
try out the changes I made by testing date picker in ie; also create a new project using cbp-theme and you should be able to add in cbp-theme.js and any jquery (as opposed to the cbp-theme specific one) |
|
You will need to add the parameters: output: { |
-minify, remove comments from bundles -reorder script imports in example example kitchen sink app -added jQuery in 3rd party folder in example kitchen sink app -made jQuery external dependency in webpack (looks for global / script tag) -export cbp-theme.js as UMD module -remove jQuery from package.json dependencies (looking for it as global script var in browser now) see issues #24, #56, #59
…ipt tag for cbp-theme
…pers. Also moved alternative installation methods (webjars/gradle) to separate file. See issue #57.
|
Closing per discussion with @tma001 regarding new PR for upstream changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-made jQuery external dependency in webpack (looks for global / script tag)
-export cbp-theme.js as UMD module
-added polyfill for ie11 object.asign (for input mask)
See issues #24, #56