Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refac ghg national mecsallocationfix #321

Merged
merged 23 commits into from
Feb 22, 2023

Conversation

catherinebirney
Copy link
Collaborator

Update attribution of EIA MECS using BEA. Resolves attribution errors.

Copy link
Collaborator

@WesIngwersen WesIngwersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now passing validation checks, thanks @catherinebirney . However I will keep this branch open until i make further changes related to application of this MECS allocation

@WesIngwersen
Copy link
Collaborator

running 2016 locally from e964ef3

@bl-young
Copy link
Collaborator

I'm just waiting for 2020 to finish then I can post all to sharepoint.

@WesIngwersen
Copy link
Collaborator

WesIngwersen commented Feb 18, 2023

There are a number of balance check issues in my local run of 2016. I confirm i updated my local BEA Make and Use FBAs before the run. All the FBAs for the GHGI tables referred to below were created on 2023 -01-26 so reflect the new GHGI

petroleum in EPA_GHGI_T_3_22b (1.53% less than FBA)

coal_manufacturing in EPA_GHGI_T_A_9 (4.69% less)
natural_gas_manufacturing in EPA_GHGI_T_A_9 (0.03% less than FBA)

coal_manufacturing in EPA_GHGI_T_3_8 (0.23% more than FBA))
ng_manufacturing in EPA_GHGI_T_3_8 (0.03% less than FBA)
ng_manufacturing in EPA_GHGI_T_3_9 (0.03% less than FBA)

@bl-young
Copy link
Collaborator

At a glance I was not able to identify where those data loss are coming from. May need @catherinebirney to review the EIA MECS/BEA functions. I have a hard time following those. I will say that one possible thing to explore is whether difference in NAICS years could be causing a small issue see #212

@WesIngwersen
Copy link
Collaborator

Basically petroleum is handled just as it was before for stationary combustion, where as there were no errors in the petroleum activity set before

@WesIngwersen WesIngwersen merged commit 4cf2593 into refac_GHG_national Feb 22, 2023
@bl-young bl-young deleted the refac_GHG_national_mecsallocationfix branch February 22, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants