Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting knitr to work again #401

Closed
wants to merge 2 commits into from
Closed

Conversation

ldecicco-USGS
Copy link
Member

No description provided.

@@ -22,7 +22,8 @@ loadConfig = function(filename) {
}

graphTemplate <- yaml.load_file(filename)
if(.Device != "null device"){

if(!(.Device %in% c("null device","png"))){
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so seemed like a great/easy/straightforward solution. Until I discovered the graphs weren't working right in knitr.

I'm not super-happy with this hack. The alternative I think is comparing original.par with new par. That being said....this line does work in all cases I can envision. The situation where it could be problematic that I want to test is changing the config file mid-knitr doc.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.523% when pulling 754800d on ldecicco-USGS:master into bc8f472 on USGS-R:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants