aggregating NWM retro and forecast discharge #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2_munge/src/aggregate_inputs.R
Outdated
| })) # need to figure out what valid date vals mean; what are the time steps? | ||
| })) %>% | ||
| mutate(valid_date = as.character(as.POSIXlt(ref_date) + as.difftime(valid_date * valid_time_step, units = 'hours'))) %>% | ||
| mutate(valid_date = as.Date(valid_date)) %>% |
There was a problem hiding this comment.
what happens if you merge the above two lines into a single one,
mutate(valid_date = as.Date(as.POSIXlt(ref_date) + as.difftime(valid_date * valid_time_step, units = 'hours')))
? does it work?
There was a problem hiding this comment.
oh yeah, that was dumb; I'll push up edit. good catch!
|
|
||
| #need to figure out which site_no of the duplicates are correct; | ||
| # looks like the second half of the all the site pulls are correct; but need to check this later if new sites are added | ||
| site_inds <- site_inds[4:6] |
There was a problem hiding this comment.
noted. it'll be good to have something workable in the meantime.
aappling-usgs
approved these changes
May 14, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggregation of NWM discharge to daily mean discharge. Through visual inspection, the second duplicated sites brought up in issue #42 and PR #44 seem to be the correct discharge values for those sites. These could be chosen in a more intelligent way than visual inspection so I'm leaving #42 still open for now. This PR closes #34