Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing text shadow on image overlay text #368

Merged
merged 2 commits into from
Feb 6, 2020

Conversation

Maxxen
Copy link
Contributor

@Maxxen Maxxen commented Feb 4, 2020

Description of the Change

Adds text shadow property to paragraph and title of image overlay blocks, so they are able to stand out and be legible on lighter image backgrounds. This is the same text shadow value as is present on the page banner sections who would otherwise suffer from the same issue.

Applicable Issues

None

@Maxxen Maxxen changed the title fix missing text shadow on image overlay title text fix missing text shadow on image overlay text Feb 4, 2020
Copy link
Member

@dakaza98 dakaza98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bra grej!

@dakaza98 dakaza98 merged commit 2180071 into development Feb 6, 2020
@dakaza98 dakaza98 deleted the fix-image-overlay-shadow branch February 6, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants