fix better positioning and stacking of logos of even amount #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amounts using flexbox
|
Examples of new improved behavior for 4, 2, and 8 logos |
Maxxen
changed the title
dakaza98
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This change makes the logo block use flexbox to scale, position and wrap around logos properly.
Previously, if less than 3 logos were present, an empty fake column was inserted to offset the row and make them look somewhat centered. This didn't work as intended when there was only one logo present, since it was just offset from already being centered thanks to the fake column. Now logos instead flex to fit the remaining space, and wrap to a new row once a row contains more than 3 logos, thanks to
flex-basis: 33%(this is consistent with the current behaviour, but max row size could easily be changed by modifying flex basis). A breakpoint for small screens is also set which triggers the logos to arrange themselves in a column instead of rows.Applicable Issues
None