Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add two column image grid noyce block type #370

Merged
merged 9 commits into from
Feb 11, 2020
Merged

Conversation

Maxxen
Copy link
Contributor

@Maxxen Maxxen commented Feb 5, 2020

Description of the Change

This adds a new "two-column-grid" block type. It is pretty nice to make informative and pretty layouts. It especially good to use as a primary component of a home page to provide more intuitive links to sub-pages.

The following images use only two rows, but it is possible to add more and swap image and paragraph places.

Row height is also configurable

Images

On desktop

Screenshot_2020-02-05 Homepage - Uppsala Union of Engineering and Science Students

On mobile (breakpoint medium-and-down)

Screenshot_2020-02-05 Homepage - Uppsala Union of Engineering and Science Students

Applicable Issues

None

@Maxxen
Copy link
Contributor Author

Maxxen commented Feb 5, 2020

Thanks Travis!

Copy link
Member

@dakaza98 dakaza98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jag tror att det här blocket kommer vara användbart för fler än er! Snyggt gjort!

src/blocks/models.py Show resolved Hide resolved
src/blocks/models.py Outdated Show resolved Hide resolved
src/blocks/models.py Show resolved Hide resolved
@dakaza98
Copy link
Member

dakaza98 commented Feb 5, 2020

image

Scrollbar som dyker upp fast den inte behövs när man använder overflow-y: scroll

@Maxxen
Copy link
Contributor Author

Maxxen commented Feb 7, 2020

Okay! requested changes are made, does it look good? @dakaza98

@Maxxen Maxxen requested a review from dakaza98 February 7, 2020 15:04
Copy link
Member

@dakaza98 dakaza98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dakaza98 dakaza98 merged commit 5c6040e into development Feb 11, 2020
@dakaza98 dakaza98 deleted the add-two-column-grid branch February 11, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants