Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string representation of logo #402

Merged
merged 3 commits into from
Apr 16, 2020

Conversation

dakaza98
Copy link
Member

Logos don't have a string representation which makes the text at the top look like this:
image

With this change it will look like this:
image

Since each logo doesn't have a name or similar, the text can not be different for each logo

Copy link
Contributor

@Maxxen Maxxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was unaware that this was a thing, but looks good. I suppose "logo" string already has a translation?

@dakaza98
Copy link
Member Author

Was unaware that this was a thing, but looks good. I suppose "logo" string already has a translation?

Yes

@dakaza98 dakaza98 merged commit 91ad13f into development Apr 16, 2020
@dakaza98 dakaza98 deleted the add-logo-string-representation branch April 16, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants