Skip to content

Fix/grid reset page #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2022
Merged

Fix/grid reset page #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b21d7c5
fix(grid): set first page when page index exists
CatalinB7 May 12, 2022
39aad1b
chore: bump version
CatalinB7 May 12, 2022
8e69c08
fix(grid): set page index in tests
CatalinB7 May 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# v13.3.2 (2022-05-12)
* **grid** set first page when page index exists

# v13.3.1 (2022-05-11)
* **grid** set proper import path

Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "angular-components",
"version": "13.3.1",
"version": "13.3.2",
"author": {
"name": "UiPath Inc",
"url": "https://uipath.com"
Expand Down
1 change: 1 addition & 0 deletions projects/angular/components/ui-grid/src/managers/filter-manager.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ describe('Component: UiGrid', () => {

it('should set page index to 0', (done) => {
const footer = new UiGridFooterDirective();
footer.state.pageIndex = 2;
footer.pageChange
.pipe(
first(),
Expand Down
10 changes: 6 additions & 4 deletions projects/angular/components/ui-grid/src/managers/filter-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,12 @@ export class FilterManager<T> {
header.searchValue = term;
header.searchTerm.emit(term);
header.searchFilter.emit(searchFilterCollection);
footer?.pageChange.emit({
pageIndex: 0,
pageSize: footer.state.pageSize,
});
if (footer?.state.pageIndex) {
footer.pageChange.emit({
pageIndex: 0,
pageSize: footer.state.pageSize,
});
}
}

private _updateFilterValue = (
Expand Down
2 changes: 1 addition & 1 deletion projects/angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@uipath/angular",
"version": "13.3.1",
"version": "13.3.2",
"license": "MIT",
"author": {
"name": "UiPath Inc",
Expand Down