fix(suggest): add aria-selected to item #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gheorghitahurmuz
requested review from
a team,
CatalinB7 and
alexdudescu
and removed request for
a team
|
We need this fix for older releases too? |
gheorghitahurmuz
force-pushed
the
feat/suggest-a11y-selected-item
branch
from
f29e32c to
9ce3c2a
Compare
gheorghitahurmuz
changed the title
Yes, we need. This is for |
CatalinB7
previously approved these changes
May 10, 2023
|
dont forget to bump |
|
Code Climate has analyzed commit 670ef0d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 91.9% (0.0% change). View more on Code Climate. |
CatalinB7
approved these changes
May 10, 2023
gheorghitahurmuz
added a commit
that referenced
this pull request
Dec 12, 2023
fix(suggest): add aria-selected to item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggest-selected-item.mp4