Skip to content

feat(a11y): add tabIndex to matIcons with matTooltips #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2023
Merged

feat(a11y): add tabIndex to matIcons with matTooltips #345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions projects/angular/a11y/src/ui-auto-accessible-label/ui-auto-accessible-label.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ import {
ElementRef,
HostBinding,
Input,
OnChanges,
Optional,
SimpleChanges,
} from '@angular/core';
import { MatTooltip } from '@angular/material/tooltip';

Expand All @@ -23,19 +25,32 @@ You can disable this directive using the boolean ${DISABLE_AUTO_ACCESSIBLE_LABEL
selector: ` [mat-fab]:not([${DISABLE_AUTO_ACCESSIBLE_LABEL_ATTRIBUTE}]),
[mat-mini-fab]:not([${DISABLE_AUTO_ACCESSIBLE_LABEL_ATTRIBUTE}]),
[mat-icon-button]:not([${DISABLE_AUTO_ACCESSIBLE_LABEL_ATTRIBUTE}]),
mat-icon[tabindex]:not([${DISABLE_AUTO_ACCESSIBLE_LABEL_ATTRIBUTE}])`,
mat-icon:not([${DISABLE_AUTO_ACCESSIBLE_LABEL_ATTRIBUTE}])`,
})
export class UiAutoAccessibleLabelDirective {
export class UiAutoAccessibleLabelDirective implements OnChanges {
@HostBinding('attr.aria-label')
@Input()
matTooltip?: string;

constructor(
elementRef: ElementRef,
private _elementRef: ElementRef<HTMLUnknownElement>,
@Optional() tooltip?: MatTooltip,
) {
if (!tooltip) {
console.warn(MAT_TOOLTIP_MISSING_WARNING, elementRef.nativeElement);
if (!tooltip && _elementRef.nativeElement.tabIndex !== -1) {
console.warn(MAT_TOOLTIP_MISSING_WARNING, _elementRef.nativeElement);
}
}

ngOnChanges(changes: SimpleChanges) {
if (changes.matTooltip) {
const element = this._elementRef.nativeElement;
if (
element.tagName === 'MAT-ICON'
&& !!changes.matTooltip.currentValue
&& element.tabIndex === -1
) {
element.tabIndex = 0;
}
}
}
}