This repository has been archived by the owner on Oct 12, 2020. It is now read-only.
Add fast mode #17
Merged
Add fast mode #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Fixes #10
This PR addresses Astronomer's biggest issue at the moment: it is slow. That's why this PR adds the fast mode, enabled by default. The fast mode ensures that if a repository contains more than (by default) 1000 stars, only 1000 random stargazers will be scanned among all.
The fast mode can be disabled by adding
--fast=false. The amount of stars to compute in fast mode can also be changed by using the-sor--starsoption.This means that with the default value of 1000, scanning a big repository with thousands of stars takes about 25-30 minutes. (was multiple days in the
v0.1.xand about 10 hours per 30K stars in thev0.2.0&0.3.0)Examples