-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create automated system to compare kicad diffs #24
Comments
Awesome thought of automating this! Just made you a collaborator of this repo with write access, and assigned this issue to you. Sorry for the delay regarding the other issues, I'll catch up later on. Thank you so much! |
Awesome thanks. |
I have a working implementation in this branch in my fork https://github.com/spuder/electronics/tree/feature/wip_travis It still has the following issues:
|
Stand by, i'll be pushing a script soon that uses vagrant and the kicad python api to make images showing diffs. Its as native as can be right now |
I have opened merge request #27 It has a fairly polished collection of scripts that when run generate 14 pdf files, converts them to .png files, and then runs
The script that generates the plots is located externally here: https://gist.github.com/spuder/4a76e42f058ef7b467d9 It still could use some minor improvements, but it is good enough to see at a glance exactly what was changed. It also has a travis config file, that runs these scripts. Here is what happens if nothing has changed: https://travis-ci.org/spuder/electronics/builds/98057604 Here is what it looks like when a change is made to a file ending in .kicad_pcb https://travis-ci.org/spuder/electronics/builds/97929762 There are still two remaining tasks
I'll keep working on those, but I want to merge what I have now so that people can use these scripts without waiting. Here are some samples of what happens when the kicad_file is edited. Here I intentionally moved the rj11 connector: |
I'm absolutely thrilled about this, thank you so much @spuder! Let me merge the relevant pull request real quick. |
@timofonic Sure thing, everybody's welcome to hack the schematic! Let me know if you need any help. |
Marking as done. I'll update the README instructing users to upload their diffs manually. |
@spuder Thank you for your hard work, this looks excellent the way it is! The rest is only icing on the cake and certainly not urgent. |
As an alternative, you might want to have a look at the very powerful KiBot tool. |
When a new merge request is made. Use travis-ci to generate gerbers/pdf/png files and then use
linux compare
to generate a visual diff.http://www.evilmadscientist.com/2011/improving-open-source-hardware-visual-diffs/
https://github.com/blairbonnett-mirrors/kicad/blob/master/demos/python_scripts_examples/plot_board.py
You can assign this to me as I'm currently working on it.
The text was updated successfully, but these errors were encountered: