-
Notifications
You must be signed in to change notification settings - Fork 15
Fix: Corrects SubplotGrid
indexing and sequential GeoAxes
formatting
#357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
beckermr
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #356 and #358
This PR addresses two critical bugs introduced after v1.0: one causing incorrect indexing in
SubplotGrid
, and another causing sequentialformat
calls onGeoAxes
to override each other.While this work is part of the larger effort in #349, this fix is being prioritized to resolve significant issues for users on the latest version.
Gridspec Indexing Bug
SubplotGrid
using 2D grid coordinates (e.g.,axs[:, 0]
) resulted in an incorrect selection of axes.SubplotGrid.__getitem__
method inultraplot/gridspec.py
has been reverted to the robust implementation from v1.0, which correctly handles array-like indexing.Sequential Formatting Bug
GeoAxes
object in sequence, the second call would override the first. For example, setting longitude labels withax.format(lonlabels=True)
and then latitude labels withax.format(latlabels=True)
would result in only the latitude labels being displayed._to_label_array
inultraplot/axes/geo.py
was incorrectly defaulting unspecified label sides toFalse
. It has been modified to useNone
instead, ensuring that only the explicitly passed labels are modified and preserving the state of other labels from previousformat
calls.