Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unnecessary imports. #226

Merged
merged 3 commits into from
Nov 5, 2022

Conversation

m-lindgren
Copy link
Member

@m-lindgren m-lindgren commented Nov 2, 2022

This removes the imports of UniMath.CategoryTheory.All from TypeTheory, based on the discussions in UniMath/UniMath#1589 and UniMath/UniMath#1588.

@m-lindgren
Copy link
Member Author

UniMath failed to build, which is strange.

make[2]: *** No rule to make target 'UniMath/Tactics/EnsureStructuredProofs.vo', needed by 'UniMath/PAdics/lemmas.vo'.  Stop.
make[1]: *** [build/CoqMakefile.make:387: all] Error 2
make[1]: Leaving directory '/home/runner/work/TypeTheory/UniMath'
make: *** [Makefile:98: all] Error 2
Error: Process completed with exit code 2.

@rmatthes
Copy link
Member

rmatthes commented Nov 3, 2022

The PAdics import should be unnecessary, see a remark by Niels, as is remembered in issue #225.

rmatthes and others added 2 commits November 4, 2022 17:06
deletes superfluous import of Rezk completion
adds necessary import of Rezk completion
@benediktahrens benediktahrens merged commit 71a4afe into UniMath:master Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants