Skip to content

Download action on single element #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2018
Merged

Conversation

juancho85
Copy link

I noticed that the download was not working on my project and I've found that the name attribute could not be found on script.js

function download(item) { var data = defaultParameters(); data['file'] = item.name; location.href = lfm_route + '/download?' + $.param(data); }
It is because the actions has is defined as multiple on index.blade.php

I'm not sure if the expected behavior is to allow multiple downloads (in which case the modificacion should be to iterate though the items on script.js on the download function) or the fix I'm proposing here

@streamtw
Copy link
Member

Thank you @juancho85 , downloading multiple files is a feature that has not been done. We should fix that before beta version.

@streamtw streamtw merged commit b1dda59 into UniSharp:master Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants