Make toMethodResult function safer #1720
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace in the
toMethodResult
function unsafe access to soot classes with a safe one (surprisingly calledunsafe
). If we cannot upload a concrete type from the Runtime, we create an unbounded variable with a type belonging to a field we construct.Fixes #1670
Type of Change
How Has This Been Tested?
Regression and integration tests
There are no regression tests since it is quite hard to imitate the problem since it'd require working with a "broken" classpath.
Automated Testing
There are no automatic tests due for the same reason.
Manual Scenario
Run contest estimator reproducing steps from #1670 and check that there are no produced errors.
Checklist: