Skip to content

Make toMethodResult function safer #1720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

CaelmBleidd
Copy link
Member

@CaelmBleidd CaelmBleidd commented Jan 19, 2023

Description

Replace in the toMethodResult function unsafe access to soot classes with a safe one (surprisingly called unsafe). If we cannot upload a concrete type from the Runtime, we create an unbounded variable with a type belonging to a field we construct.

Fixes #1670

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Regression and integration tests

There are no regression tests since it is quite hard to imitate the problem since it'd require working with a "broken" classpath.

Automated Testing

There are no automatic tests due for the same reason.

Manual Scenario

Run contest estimator reproducing steps from #1670 and check that there are no produced errors.

Checklist:

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • No new warnings
  • All tests pass locally with my changes

@CaelmBleidd CaelmBleidd added comp-symbolic-engine Issue is related to the symbolic execution engine ctg-bug-fix PR is fixing a bug labels Jan 19, 2023
@CaelmBleidd CaelmBleidd requested a review from Damtev January 19, 2023 14:36
@CaelmBleidd CaelmBleidd force-pushed the caelmbleidd/to_method_result_fix branch from acadf4a to d834967 Compare January 19, 2023 14:47
@CaelmBleidd CaelmBleidd enabled auto-merge (squash) January 19, 2023 14:53
@CaelmBleidd CaelmBleidd disabled auto-merge January 19, 2023 15:01
@CaelmBleidd CaelmBleidd merged commit b5578ce into main Jan 19, 2023
@CaelmBleidd CaelmBleidd deleted the caelmbleidd/to_method_result_fix branch January 19, 2023 16:07
@alisevych alisevych added this to the 2023.03 Release milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-symbolic-engine Issue is related to the symbolic execution engine ctg-bug-fix PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RefType sun.nio.cs.UTF_8 not loaded in seata-core-0.5.0 project
3 participants