Skip to content

Conversation

Vassiliy-Kudryashov
Copy link
Member

@Vassiliy-Kudryashov Vassiliy-Kudryashov commented Mar 7, 2023

kotlin.Streams.toList clashes with java.util.stream.Stream#toList when both project and Gradle are under Java 17

Title Fix broken code after migration to Java 17

Previously used kotlin.Streams.toList now clashes with java.util.stream.Stream#toList (that is available since Java 16 only).
As we declare compatibility with old versions of Java we cannot use java.util.stream.Stream#toList
New "asList" methods were added locally to avoid the conflict.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@Vassiliy-Kudryashov Vassiliy-Kudryashov added the ctg-refactoring Issue related to refactoring process label Mar 7, 2023
@Vassiliy-Kudryashov Vassiliy-Kudryashov changed the title kotlin.Streams.toList clashes with java.util.stream.Stream#toList whe… Fix broken compilation after mighration to java 17 Mar 7, 2023
@Vassiliy-Kudryashov Vassiliy-Kudryashov enabled auto-merge (squash) March 7, 2023 10:51
@Vassiliy-Kudryashov Vassiliy-Kudryashov merged commit 1db6355 into main Mar 7, 2023
@Vassiliy-Kudryashov Vassiliy-Kudryashov deleted the Vassiliy-Kudryashov/Stream.toList_compatibility_issue branch March 7, 2023 11:26
@alisevych alisevych added this to the 2023.03 Release milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ctg-refactoring Issue related to refactoring process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants