Skip to content

Use more safe approach to analyze Spring xml configs #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Use more safe approach to analyze Spring xml configs #2126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions utbot-ui-commons/src/main/kotlin/org/utbot/intellij/plugin/models/BaseTestModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,14 +127,21 @@ open class BaseTestsModel(

val builder = DocumentBuilderFactory.newInstance().newDocumentBuilder()
return xmlFilePaths.mapNotNullTo(mutableSetOf()) { path ->
val doc = builder.parse(path.toFile())

val hasBeanTagName = doc.documentElement.tagName == "beans"
val hasAttribute = doc.documentElement.getAttribute("xmlns") == "http://www.springframework.org/schema/beans"
when {
hasBeanTagName && hasAttribute -> path.toString()
else -> null
try {
val doc = builder.parse(path.toFile())

val hasBeanTagName = doc.documentElement.tagName == "beans"
val hasAttribute = doc.documentElement.getAttribute("xmlns") == "http://www.springframework.org/schema/beans"
when {
hasBeanTagName && hasAttribute -> path.toString()
else -> null
}
} catch (e: Exception) {
// Sometimes xml parsing may fail, for example, when it references external DTD schemas.
// See https://stackoverflow.com/questions/343383/unable-to-parse-xml-file-using-documentbuilder.
null
}

}
}

Expand Down