Skip to content

Divide Spring unit and integration testing in codegen #2230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2023
Merged

Divide Spring unit and integration testing in codegen #2230

merged 2 commits into from
May 23, 2023

Conversation

EgorkaKulikov
Copy link
Collaborator

Description

  • Introduce tests type: unit and integration
  • Differ codegen process for Spring unit and integration tests

How to test

Automated tests

Verify that there are no regressions in unit testing, integration are not yet ready.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@EgorkaKulikov EgorkaKulikov added ctg-enhancement New feature, improvement or change request comp-codegen Issue is related to code generator comp-spring Issue is related to Spring projects support labels May 22, 2023
@EgorkaKulikov EgorkaKulikov requested a review from Damtev May 22, 2023 14:08
Damtev
Damtev requested changes May 22, 2023
View reviewed changes
Damtev
Damtev requested changes May 23, 2023
View reviewed changes
Damtev
Damtev requested changes May 23, 2023
View reviewed changes
Copy link
Member

@Damtev Damtev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EgorkaKulikov EgorkaKulikov force-pushed the egor/cg_integration_tests branch from f0423dd to 08f288d Compare May 23, 2023 11:17
@EgorkaKulikov EgorkaKulikov force-pushed the egor/cg_integration_tests branch from 08f288d to 9b51f38 Compare May 23, 2023 11:23
@EgorkaKulikov EgorkaKulikov enabled auto-merge (squash) May 23, 2023 11:48
@EgorkaKulikov EgorkaKulikov merged commit 46fcd2a into main May 23, 2023
@EgorkaKulikov EgorkaKulikov deleted the egor/cg_integration_tests branch May 23, 2023 11:53
@alisevych alisevych mentioned this pull request May 26, 2023
Closed
@EgorkaKulikov EgorkaKulikov mentioned this pull request May 31, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Damtev Damtev Damtev approved these changes

Assignees

No one assigned

Labels

comp-codegen Issue is related to code generator comp-spring Issue is related to Spring projects support ctg-enhancement New feature, improvement or change request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EgorkaKulikov @Damtev