Skip to content

Make JDK names more readable (in unsupported version warning) #2646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2023
Merged

Make JDK names more readable (in unsupported version warning) #2646

merged 1 commit into from
Oct 5, 2023

Conversation

Vassiliy-Kudryashov
Copy link
Member

Description

Fixes #2635

Manual tests

See the issue, suggested text is implemented in UI and updated in test assertion check

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@Vassiliy-Kudryashov Vassiliy-Kudryashov added ctg-enhancement New feature, improvement or change request comp-ui Improvements of plugin UI appearence and functionality labels Oct 4, 2023
@Vassiliy-Kudryashov Vassiliy-Kudryashov enabled auto-merge (squash) October 4, 2023 16:07
@Vassiliy-Kudryashov Vassiliy-Kudryashov merged commit 4bb4329 into main Oct 5, 2023
@Vassiliy-Kudryashov Vassiliy-Kudryashov deleted the Vassiliy-kudryashov/2635-use-better-jdk-names-in-unsupported-version-warning branch October 5, 2023 07:12
alisevych pushed a commit that referenced this pull request Oct 5, 2023
@Vassiliy-Kudryashov @alisevych
Make JDK names more readable (in unsupported version warning) (#2646)
25b6ab4 
Use better JDK names in unsupported version warning #2635

(cherry picked from commit 4bb4329)
Vassiliy-Kudryashov added a commit that referenced this pull request Oct 9, 2023
@Vassiliy-Kudryashov @alisevych
Update plugin.xml and plugin-specific services to actual IntelliJ API (…
e3f5516 
…#2654)

* Update change notes in plugin.xml for release 2023.10

* Make JDK names more readable (in unsupported version warning) (#2646)

Use better JDK names in unsupported version warning #2635

(cherry picked from commit 4bb4329)

* Correct plugin description in plugin.xml

* Update plugin.xml and plugin-specific services to actual API

---------

Co-authored-by: Vassiliy.Kudryashov <Vassiliy.Kudryashov@huawei.com>
Co-authored-by: Alena Lisevych <alena.lisevych@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgorkaKulikov EgorkaKulikov EgorkaKulikov approved these changes

Assignees
No one assigned
Labels
comp-ui Improvements of plugin UI appearence and functionality ctg-enhancement New feature, improvement or change request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use better JDK names in unsupported version warning
2 participants
@Vassiliy-Kudryashov @EgorkaKulikov