Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autostart parameter to prevent immediately starting #5780

Closed
wants to merge 5 commits into from

Conversation

ultimate-tester
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #5711
License MIT
Doc PR https://github.com/pm2-hive/pm2-hive.github.io/pulls

@CLAassistant
Copy link

CLAassistant commented Mar 8, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ Unitech
✅ ultimate-tester
❌ Your Name


Your Name seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ultimate-tester
Copy link
Contributor Author

I am not "Your Name" who appears in the list to sign so nothing for me to do here.

@mudmixer-wes
Copy link

@ultimate-tester thanks so much for your work on this. Can't wait to see this go live.

Is the license/cla task for you to complete or someone at Unitech?

@ultimate-tester
Copy link
Contributor Author

@ultimate-tester thanks so much for your work on this. Can't wait to see this go live.

Is the license/cla task for you to complete or someone at Unitech?

I already did mine, but there's someone in the list called "Your Name" which is not me looking at which commits are done by that person. No idea who is this :/

@mudmixer-wes
Copy link

@Unitech can you help @ultimate-tester know what needs to happen so we can get all contributor related steps checked off on this PR?

@ultimate-tester
Copy link
Contributor Author

I resubmitted the pull request without the commits of "Your Name" which was caused by using the wrong branch.
New PR is #5782

@alexgalkin
Copy link

I am not "Your Name" who appears in the list to sign so nothing for me to do here.

Please make sure that your branch is created from the same branch your PR is pointed to (development). Currently there is a difference between your branch and development in 5 commits so most likely you have created it from some other branch where Your Name's commits were in place.

https://github.com/Unitech/pm2/pull/5780/commits

@alexgalkin
Copy link

I am not "Your Name" who appears in the list to sign so nothing for me to do here.

Please make sure that your branch is created from the same branch your PR is pointed to (development). Currently there is a difference between your branch and development in 5 commits so most likely you have created it from some other branch where Your Name's commits were in place.

https://github.com/Unitech/pm2/pull/5780/commits

nevermind, missed that there is new PR already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants