Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Client Driven Art Pass #68

Merged
merged 25 commits into from Dec 1, 2022
Merged

Feat: Client Driven Art Pass #68

merged 25 commits into from Dec 1, 2022

Conversation

jilfranco-unity
Copy link
Contributor

Description

A PR for the first art pass on the client driven sample! I've used the starter assets as well as some custom assets & shaders to dress up our level. Final animation setup will come in a PR after the third person controller PR is merged into develop.

Pictures

Overall Level:

image
image

Ingredients:

image
image
image

Stoves:

image
image

Drop Zones:

image
image

fernando-cortez and others added 16 commits November 2, 2022 13:36
@fernando-cortez
update clientdriven sample to 2021.3.12f1
af30a9e
@fernando-cortez
third person controller assets added
68d3842
@fernando-cortez
dependencies updated
030f1e1
@jilfranco-unity
First pass of art level art updates and URP port
7d79fd7
@jilfranco-unity
Added carrying animation to project
c27e9a3
@jilfranco-unity
Environment Art Pass
defabff
@jilfranco-unity
Animation import setting edits
3052908
@jilfranco-unity
More environment art pass, specifically on drop zones and stoves
ad6c71b
@jilfranco-unity
Dropzone ingredient animation
b41fa9c
@jilfranco-unity
Animated ingredient materials
c249979
@jilfranco-unity
More overall theme changes, as well as some small bug fixes
d99612f
@jilfranco-unity
Merge branch 'develop' into feat/client-driven-art-pass (Merged using…
9f829ef 
… mine)

# Conflicts:
#	Basic/ClientDriven/Assets/StarterAssets/Environment/Art/Materials/GreyBlue_Mat.mat
#	Basic/ClientDriven/Assets/StarterAssets/Environment/Art/Materials/GridBlue_01_Mat.mat
#	Basic/ClientDriven/Assets/StarterAssets/Environment/Art/Materials/GridOrange_01_Mat.mat
#	Basic/ClientDriven/Assets/StarterAssets/Environment/Art/Materials/URP_HDRP_ShaderGraph/ShaderGraphGrid_01_Mat.mat
#	Basic/ClientDriven/Assets/StarterAssets/Environment/Art/Models/Box_350x250x200_Mesh.fbx.meta
#	Basic/ClientDriven/Assets/StarterAssets/Environment/Art/Models/Box_350x250x300_Mesh.fbx.meta
#	Basic/ClientDriven/Assets/StarterAssets/Environment/Art/Models/Ground_Mesh.fbx.meta
#	Basic/ClientDriven/Assets/StarterAssets/Environment/Art/Models/Ramp_100x100x200_Mesh.fbx.meta
#	Basic/ClientDriven/Assets/StarterAssets/Environment/Art/Models/Ramp_Mesh.fbx.meta
#	Basic/ClientDriven/Assets/StarterAssets/Environment/Art/Models/Stairs_200x100x200_Mesh.fbx.meta
#	Basic/ClientDriven/Assets/StarterAssets/Environment/Art/Models/Stairs_650_400_300_Mesh.fbx.meta
#	Basic/ClientDriven/Assets/StarterAssets/Environment/Art/Models/Structure_Mesh.fbx.meta
#	Basic/ClientDriven/Assets/StarterAssets/Environment/Art/Models/Tunnel_Mesh.fbx.meta
#	Basic/ClientDriven/Assets/StarterAssets/Environment/Art/Models/Wall_Mesh.fbx.meta
#	Basic/ClientDriven/Assets/StarterAssets/Environment/Art/Skybox/SkyboxLite.mat
#	Basic/ClientDriven/Assets/StarterAssets/Environment/Prefabs/Environment_Prefab.prefab
#	Basic/ClientDriven/Assets/StarterAssets/Environment/Shaders/URP_HDRP_ShaderGraph/UrpTriplanar.shadergraph
#	Basic/ClientDriven/Assets/StarterAssets/ThirdPersonController/Character/Animations/Jump--InAir.anim.fbx.meta
#	Basic/ClientDriven/Assets/StarterAssets/ThirdPersonController/Character/Animations/Jump--Jump.anim.fbx.meta
#	Basic/ClientDriven/Assets/StarterAssets/ThirdPersonController/Character/Animations/Locomotion--Run_N.anim.fbx.meta
#	Basic/ClientDriven/Assets/StarterAssets/ThirdPersonController/Character/Animations/Locomotion--Run_N_Land.anim.fbx.meta
#	Basic/ClientDriven/Assets/StarterAssets/ThirdPersonController/Character/Animations/Locomotion--Run_S.anim.fbx.meta
#	Basic/ClientDriven/Assets/StarterAssets/ThirdPersonController/Character/Animations/Locomotion--Walk_N.anim.fbx.meta
#	Basic/ClientDriven/Assets/StarterAssets/ThirdPersonController/Character/Animations/Locomotion--Walk_N_Land.anim.fbx.meta
#	Basic/ClientDriven/Assets/StarterAssets/ThirdPersonController/Character/Animations/Stand--Idle.anim.fbx.meta
#	Basic/ClientDriven/Assets/StarterAssets/ThirdPersonController/Character/Models/Armature.fbx.meta
#	Basic/ClientDriven/Assets/StarterAssets/ThirdPersonController/Prefabs/MainCamera.prefab
#	Basic/ClientDriven/Packages/manifest.json
#	Basic/ClientDriven/Packages/packages-lock.json
@jilfranco-unity
Updated shadow biases to remove banding
30f66b8
@jilfranco-unity
New GUIDs for these assets
bbe8706
@jilfranco-unity
Turned off cast shadows on some object
774b320
@jilfranco-unity
Updated shadow bias again to fix cracks in shadows
5b945f6
@jilfranco-unity jilfranco-unity added the enhancement New feature or request label Nov 15, 2022
@SamuelBellomo
Copy link
Contributor

SamuelBellomo commented Nov 17, 2022 •
edited by jilfranco-unity

Great job on this, this looks amazing!
Nit picking: The purple ingredients seem to have a weird contrast on the purple background. Dunno if we should play with an additional color in there, to add more contrast?

@jilfranco-unity
Merge branch 'develop' into feat/client-driven-art-pass
193422c
@jilfranco-unity
Updated ingredient materials
b90e00c 
(most notably making the purple material a lot more white to increase contrast from the purple background)
@jilfranco-unity
Copy link
Contributor Author

Great job on this, this looks amazing! Nit picking: The purple ingredients seem to have a weird contrast on the purple background. Dunno if we should play with an additional color in there, to add more contrast?

Good shout yeah! I've updated the materials to pop a bit more from the background, going for more of an "unflavored" look for the purple ingredients. Lemme know what you think! :)

image
image
image

@chrispope
Copy link
Collaborator

Seeing a warning when testing on Mac:
Metal: Vertex shader missing buffer binding at index 0 (UnityPerDraw / Hidden/Internal-Loading)

I can not pinpoint it to any material/shader. Do we know what it means or what impact it has on the project?

@jilfranco-unity
Copy link
Contributor Author

Seeing a warning when testing on Mac: Metal: Vertex shader missing buffer binding at index 0 (UnityPerDraw / Hidden/Internal-Loading)

I can not pinpoint it to any material/shader. Do we know what it means or what impact it has on the project?

This is actually a known issue with ShaderGraph fixed in Unity 2022.2!

@chrispope
Copy link
Collaborator

Seeing a warning when testing on Mac: Metal: Vertex shader missing buffer binding at index 0 (UnityPerDraw / Hidden/Internal-Loading)
I can not pinpoint it to any material/shader. Do we know what it means or what impact it has on the project?

This is actually a known issue with ShaderGraph fixed in Unity 2022.2!

Just to confirm, that known issue relates to the VFX graph, not Shader Graph, are we sure it is the same known issue?

@chrispope chrispope removed their request for review November 25, 2022 10:18
@jilfranco-unity
Copy link
Contributor Author

Just to confirm, that known issue relates to the VFX graph, not Shader Graph, are we sure it is the same known issue?

Ah I see, yes this is a different issue. I believe it's caused by some materials still trying to use Built-In shaders instead of URP ones. I've updated them to use the URP shaders now--please let me know if you still see this issue! @chrispope

@jilfranco-unity jilfranco-unity merged commit e98f7fb into develop Dec 1, 2022
@jilfranco-unity jilfranco-unity deleted the feat/client-driven-art-pass branch December 1, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fernando-cortez fernando-cortez fernando-cortez approved these changes

@SamuelBellomo SamuelBellomo Awaiting requested review from SamuelBellomo

@RikuTheFuffs RikuTheFuffs Awaiting requested review from RikuTheFuffs

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jilfranco-unity @SamuelBellomo @chrispope @RikuTheFuffs @fernando-cortez