hack fix: disabling client side rate limiting for GDC #500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Disabling client side rate limiting for GDC, real fix should come on develop.
What this means is if we're spamming the refresh button, we'll have rate limit warnings coming from the services popping up in our logs.
Real fix would be to come back to async await and simplify the error catching flow, catch the rate limit exception and only start rate limiting client side once we get that exception (instead of doing our own client side rate limit logic which isn't the same as the one applied on the server)
Related Pull Requests
Real fix draft:
#501
Issue Number(s) (*)
MTT-2664
MTT-2668
Fixes issue(s):
Manual testing scenarios
Contribution checklist