feat: IP connection window inside main menu #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernando-cortez
added
the
1-Needs Review
|
I don't see any changes to the IP flows in lobby? Since lobby direct IP connection can't work at the moment outside of localhost, we might want to change that flow? |
Yup I remarked on that in the comments section. I'll get to that in this PR then! |
SamuelBellomo
added
2-Reviewed with Comments
LPLafontaineB
previously approved these changes
Mar 4, 2022
LPLafontaineB
added
2-One More Review
SamuelBellomo
added
2-Reviewed with Comments
fernando-cortez
added
1-Needs Review
SamuelBellomo
approved these changes
Mar 4, 2022
SamuelBellomo
added
2-One More Review
LPLafontaineB
approved these changes
Mar 4, 2022
fernando-cortez
added a commit
that referenced
this pull request
Mar 4, 2022
* ip connection window inside main menu * removing IPUIMediator's connection message publishing * removing IP from lobby flow (so relay is now default)
4 tasks
SamuelBellomo
pushed a commit
that referenced
this pull request
Mar 4, 2022
SamuelBellomo
added a commit
that referenced
this pull request
Mar 8, 2022
…ocal * release/GDC2022: Cherrypick: bigger floor tiles, bossroom.unity scene merge conflict resolved with unity merge tool (#519) Cherrypick: lobby visual rework, mainmenu.unity scene merge conflict resolved with unity merge tool (#520) cherrypick: Boss and run VFX Optimizations (#514) (#521) feat: loading screen (GDC version) (#495) fix: client writing to NetworkVariable inside ServerCharacterMovement (#517) fix: imps spawning issues when late joining (#497) Adding handling of host disconnect (#486) (#509) fix: NREs when trying to quit (#516) hack fix: disabling client side rate limiting for GDC, real fix should come on develop (#500) fix: NetworkAnimator being called on clients (#512) fix: username changing before game (#499) feat: IP connection window inside main menu (#502) (#508) # Conflicts: # Assets/BossRoom/Scenes/Startup.unity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Re-introducing IP connection to the MainMenu scene. This is triggered in the same way cheats are in-game (slash on Windows or four finger touch on mobile). Inspired by the LobbyPopup panel architecture, however for simplicity,
IPUIMediatordoesn't inject to DI.Adjustments:
FinalizeScopeConstruction()is invoked inside ClientMainMenuState regardless of authentication result. This seems necessary for DI to work elsewhere in the game.IsAuthenticatedcheck on queries for lobbies. This drastically limits warning messages in the console.Related Pull Requests
Issue Number(s) (*)
Fixes issue(s): MTT-2213
Manual testing scenarios
Questions or comments
This PR doesn't remove the IP connection option that is presently there for lobby connections. Can easily add that to this PR.
Contribution checklist