Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upgrade NVIDIA Video Codec SDK 11.0 #575

Merged
merged 5 commits into from
Mar 2, 2022
Merged

feat: Upgrade NVIDIA Video Codec SDK 11.0 #575

merged 5 commits into from
Mar 2, 2022

Conversation

karasusan
Copy link
Collaborator

@karasusan karasusan commented Dec 24, 2021 •
edited
Loading

Related issue #515

Note: Chromium supports the H264 profile level 5.2 or under.

@karasusan karasusan changed the title feat: Upgrade NVIDIA Codec SDK 11.0 feat: Upgrade NVIDIA Video Codec SDK 11.0 Dec 24, 2021
@karasusan karasusan mentioned this pull request Jan 7, 2022
Closed
@aet
Copy link
Contributor

aet commented Jan 27, 2022

At some point I was looking into updating the SDK into the very latest, but I recall there was some driver issue holding me back when running on AWS. I couldn't upgrade further than 10.0.26, maybe things have changed since then?

@karasusan
Copy link
Collaborator Author

karasusan commented Jan 31, 2022 •
edited
Loading

Nothing particularly. We haven't tested this change enough yet, I still can't merge it.
May I ask you about the issue more detail?

@aet
Copy link
Contributor

aet commented Jan 31, 2022

Tesla T4 driver version drags behind consumer hardware/desktop OS driver versions.

I think I was just experiencing a bad timing 12-18 months ago where using the latest SDK was requiring a more recent driver release than what was available for the cloud build, it's probably not an issue anymore but good to keep in mind while testing.

@karasusan
Copy link
Collaborator Author

I understood that we should test it on Tesla T4 for upgrading the SDK. It is too troublesome...

@karasusan karasusan force-pushed the feat/upgrade-nvcodec-11.0 branch 2 times, most recently from 4fafebf to 90d4709 Compare February 16, 2022 22:15
@karasusan karasusan marked this pull request as ready for review February 28, 2022 05:40
@kannan-xiao4
Copy link
Contributor

Maybe NvCodec/NvDecoder does not update version same as NvEncoder.
https://github.com/Unity-Technologies/com.unity.webrtc/tree/feat/upgrade-nvcodec-11.0/Plugin~/NvCodec/NvCodec/NvDecoder

@karasusan karasusan merged commit e49f889 into develop Mar 2, 2022
@karasusan karasusan deleted the feat/upgrade-nvcodec-11.0 branch March 2, 2022 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannan-xiao4 kannan-xiao4 kannan-xiao4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karasusan @aet @kannan-xiao4