performance: RTCRtpSender.SyncApplicationFramerate #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karasusan
changed the title
karasusan
force-pushed
the
fix/syncapplicationframerate
branch
from
401d407
to
688fa92
Compare
vl4dimir
reviewed
Aug 29, 2023
| { | ||
| taskQueue_ = std::make_unique<rtc::TaskQueue>( | ||
| taskQueueFactory->CreateTaskQueue("VideoFrameScheduler", TaskQueueFactory::Priority::NORMAL)); | ||
| scheduler_ = std::make_unique<VideoFrameScheduler>(taskQueue_->Get()); | ||
| scheduler_->Start(std::bind(&UnityVideoTrackSource::CaptureNextFrame, this)); | ||
| scheduler_->Start(std::bind(&UnityVideoTrackSource::OnUpdateVideoFrame, this)); |
There was a problem hiding this comment.
Shouldn't this line be wrapped with if (!syncApplicationFramerate_)?
Or alternatively, Start unconditionally but immediately Pause if syncApplicationFramerate_ is true? Since I see you're kind of relying on scheduler to be active, in the SetSyncApplicationFramerate function below.
There was a problem hiding this comment.
@vl4dimir
OK, I fixed the constructor to pause the scheduler at first and make syncApplicationFramerate_ true by default.
karasusan
force-pushed
the
fix/syncapplicationframerate
branch
from
688fa92
to
7fd2cb5
Compare
karasusan
force-pushed
the
fix/syncapplicationframerate
branch
from
760900e
to
659e35b
Compare
|
@karasusan Thanks for fixing this! Is there a plan for when this will be packaged so we can try it out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements Frame synchronization mode.
#803