Dockerfile in katana repo

[bkolada]

These are corrections which speeds up a bit setting up environment. This change needs improvements in docker-compose file which will be send in other repo. Also this change requires to maintain requirements file but in my opinion it's small amount which gives us a lot of time savings later.

[coveralls]

Coverage increased (+0.003%) to 68.487% when pulling 3f4a4af on bkolada:docker_for_katana into 4c0871b on Unity-Technologies:katana.

[campos-ddc]

Definitely very useful to have a docker file somewhere, but I don't think this repo is the right place (since you now create references to buildmaster and buildmaster_configuration which are irrelevant to Katana).

Does anyone else have a suggestion of where we should put this?

[mariangemarcano]

@campos-ddc I think it is ok to create a test master called buildmaster and we could remove the buildmaster_configuration as we are not using it.

[bkolada]

@campos-ddc in #296 mentioned:

Aren't any of these declared in setup.py? IMO requirements-dev should only contain things that are required for development but not every day use (the every day stuff should be in setup.py)

So let's continue this thread here.

[bkolada]

Dockerfile will be used in the developement, won’t it be? Indeed, it’s almost the same as in setup.py and in the current approach we are avoiding any package installation.

[campos-ddc]

Not sure if I got what you mean, this is what I would expect:

• If you want to develop new code for Katana, you have to run setup.py and pip install requirements-dev
• If you just want to start a server, running setup.py should be enough.

(doesn't matter if you are using a Dockerfile or not ; setup.py will usually be ran when doing a pip install -e katana/)

[bkolada]

Closed without merge. Here I achieved speeding up docker-compose up katana by ±30% of time from command to start parsing buildmasters config. Which sounds good but parsing projects takes much more time than that and it should be solved first. There is one important downside of such solution maintaining requirements.txt will take an effort. It's closed because we decided to create minimal docker container without large buildmaster.