CDSK-904 - add codebases_arg to Trigger links #354
Conversation
warcholprzemo
force-pushed
the
CDSK-904-add-sourcestamps-to-Trigger-links
branch
from
882b17a
to
6c0fc1f
Compare
warcholprzemo
changed the title
warcholprzemo
changed the title
|
|
||
| self.assertEqual(len(trigger_step_status.urls), 1) | ||
| self.assertEqual(len(trigger_links), 1) |
There was a problem hiding this comment.
Can we check this link? I mean checking the assertion value of the trigger_links element.
There was a problem hiding this comment.
I can see 1 problem with checking values of trigger_links
- trigger_links[0] is not a string but is a 3-elements tuple. Data for this tuple comes from stubbed method getURLForBuild (+codebase_arg). And if I start checking values I won't do an unittest for real tuple but stub tuple
Maybe I should check if this tuple has exactly 3 elements instead of checking values?
| brids = self.build.brids | ||
| db_results = yield self.build.builder.master.db.buildrequests\ | ||
| .getBuildRequestForStartbrids(brids) | ||
| master = self.build.builder.master | ||
| for build in db_results: | ||
| friendly_name = master.status.getFriendlyName(build['buildername']) | ||
| url = master.status.getURLForBuild(build['buildername'], build['number'], | ||
| url = master.status.getURLForBuild(build['buildername'], |
There was a problem hiding this comment.
Is it possible to pass codebases_arg to the getURLForBuild method?
I think that since this method prepares URL already, we can add codebase_arg as nonrequired parameter and delegate to it the whole URL building process including GET parameters
There was a problem hiding this comment.
I thought about it but getURLForBuild has already +getCodebasesArg(sourcestamps=sourcestamps)
If I add next parameter codebase_arg I need to do something with this computation of getCodebasesArg.
And then which parameter is more important? Can I use sourcestamps and codebase_arg together or not? Should I merge this 2 parameters before creating url params?
The simplest way was joining url with codebases_arg in prepare_trigger_links
master/buildbot/status/buildstep.py
Outdated
| @@ -380,27 +380,28 @@ def upgradeToVersion5(self): | |||
| self.wasUpgraded = True | |||
|
|
|||
| @defer.inlineCallbacks | |||
| def prepare_trigger_links(self): | |||
| def prepare_trigger_links(self, codebases_arg): | |||
There was a problem hiding this comment.
minor: It would be nice to add a docstring
warcholprzemo
force-pushed
the
CDSK-904-add-sourcestamps-to-Trigger-links
branch
from
d3da1b6
to
3894214
Compare
Add missing codebase_arg
