Incremental gc editor support #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes required to run the editor in incremental gc mode:
-Fix some missing write barriers which get hit on domain reload
-Add an API to disable incremental GC at runtime (to make it possible to switch the setting without requiring an editor restart)
-Make sure that mono_w32process_signal_finished is called even if GC is disabled (otherwise we deadlock in validation mode, as there is no finalizer thread, and child processes are never reported as exited)
-We cannot use gc descriptors in child domains when using BoehmGC, as that crashes the GC when the child domain is unloaded. This was always the case, but mono code used
mono_gc_is_movingto check for Boehm, which is no longer correct, so we now use an ifdef.