Windows support to abort blocking system calls. (#12654) #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix race condtion in socket altertable wait implementation on Windows. * Add support to abort blocking Windows mono_w32file_read/write methods.
|
Does this fix a bug on the Unity side as well? |
|
Yes it will fix this case: https://fogbugz.unity3d.com/f/cases/1028819 and probably this one too: https://fogbugz.unity3d.com/f/cases/1054137/ |
|
Cool! Can you add release notes for those fixes to this PR? |
joshpeterson
approved these changes
Feb 5, 2019
joncham
approved these changes
Feb 6, 2019
joncham
added a commit
that referenced
this pull request
Feb 13, 2019
Revert part of #1131 as it causes hangs in calls to CancelSynchronousIo
joncham
added a commit
that referenced
this pull request
Mar 4, 2019
Revert part of #1131 as it causes hangs in calls to CancelSynchronousIo
UnityAlex
pushed a commit
that referenced
this pull request
Jan 11, 2021
Revert part of #1131 as it causes hangs in calls to CancelSynchronousIo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix race condtion in socket altertable wait implementation on Windows.
Add support to abort blocking Windows mono_w32file_read/write methods.
Release note:
Mono: Fixes race condition that would cause a hang when using threaded C# sockets. (case 1028819)