Put dummy types used in ProcessImportedType in the proper namespace #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These dummy types were added in 0e66d19 so that the `ProcessImportedType` method could be added to the `IDataContractSurrogate` interface properly. However, the types were not put in the proper namespace. Recent changes to the profile stubber to handle overloaded methods correctly caused an additional `ProcessImportedType` method to be incorrectly stubbed in. This change allows the profile stubber to correctly notice that this method exists, and not stubbing is done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These dummy types were added in 0e66d19
so that the
ProcessImportedTypemethod could be added to theIDataContractSurrogateinterface properly. However, the types were notput in the proper namespace.
Recent changes to the profile stubber to handle overloaded methods
correctly caused an additional
ProcessImportedTypemethod to beincorrectly stubbed in. This change allows the profile stubber to
correctly notice that this method exists, and not stubbing is done.