Handle the empty file inode on macOS and FAT32 #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS and FAT32 partitions, we will sometimes get this inode value for more than one file. It means the file is empty. When this happens, the hash table of file shares becomes corrupt, since more then one file has the same inode. Instead, let's assume it is always fine to share empty files. (Unity case 950616).
joncham
approved these changes
Jul 8, 2019
joncham
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS and FAT32 partitions, we will sometimes get this inode value
for more than one file. It means the file is empty. When this happens,
the hash table of file shares becomes corrupt, since more then one file
has the same inode. Instead, let's assume it is always fine to share
empty files. (Unity case 950616).
This change was not applied to new Mono, originally I just applied it to old Mono. Once we switch to using new Mono to run tools (e.g. UnityLinker) by default, the problem occurred again. So this PR cherry-picks the change to the new Mono branch, and corrects Unity case 1166108.
Release notes:
UnityLinker: Allow UnityLinker to run properly on FAT32 partitions on macOS. (case 1166108).
I'll back port this change to 2018.4, 2019.1, and 2019.2.