[Android] Getting current locale using JNI #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it work JNI_OnLoad method should be called from runtime While JNI_OnLoad is not called, standard Posix variant is being used, so it should work exactly like before.
|
This looks fine to me, but I'm adding @UnityAlex as well, since he has been working with Mono issues lately. |
joshpeterson
approved these changes
Aug 12, 2019
UnityAlex
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it work JNI_OnLoad method should be called from runtime
While JNI_OnLoad is not called, standard Posix variant is being used, so it should work exactly like before.