Skip to content

Fix configure check bug and add more config checks #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Fix configure check bug and add more config checks #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 26 additions & 12 deletions adapters/Unity/UnityAdapter/GADMAdapterUnity.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,12 +127,19 @@ - (void)getInterstitial {
[strongConnector adapter:self didFailAd:error];
return;
}
[[GADMAdapterUnitySingleton sharedInstance] configureWithGameID:gameID];

if (!_interstitialAd) {
_interstitialAd = [[UADSInterstitialAd alloc] initWithPlacementId:_placementID];
_interstitialAd.delegate = self;
[_interstitialAd load];
BOOL isConfigured = [[GADMAdapterUnitySingleton sharedInstance] configureWithGameID:gameID];
if (!isConfigured) {
NSString *description =
[[NSString alloc] initWithFormat:@"%@ is not supported for this device.",
NSStringFromClass([UnityAds class])];
NSError *error = GADUnityErrorWithDescription(description);
[strongConnector adapter:self didFailAd:error];
} else {
if (!_interstitialAd) {
_interstitialAd = [[UADSInterstitialAd alloc] initWithPlacementId:_placementID];
_interstitialAd.delegate = self;
[_interstitialAd load];
}
}
}

Expand All @@ -156,12 +163,19 @@ - (void)getBannerWithSize:(GADAdSize)adSize {
[strongNetworkConnector adapter:self didFailAd:error];
return;
}
[[GADMAdapterUnitySingleton sharedInstance] configureWithGameID:gameID];

if (!_bannerAd) {
_bannerAd = [[UADSBannerAd alloc] initWithPlacementId:_placementID];
_bannerAd.delegate = self;
[_bannerAd load];
BOOL isConfigured = [[GADMAdapterUnitySingleton sharedInstance] configureWithGameID:gameID];
if (!isConfigured) {
NSString *description =
[[NSString alloc] initWithFormat:@"%@ is not supported for this device.",
NSStringFromClass([UnityAds class])];
NSError *error = GADUnityErrorWithDescription(description);
[strongNetworkConnector adapter:self didFailAd:error];
} else {
if (!_bannerAd) {
_bannerAd = [[UADSBannerAd alloc] initWithPlacementId:_placementID];
_bannerAd.delegate = self;
[_bannerAd load];
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion adapters/Unity/UnityAdapter/GADMAdapterUnitySingleton.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ -(BOOL)configureWithGameID:(NSString *)gameID {
if ([UnityAds isSupported]) {
if (![UnityAds isInitialized]) {
[UnityAds initialize:gameID];
return YES;
}
return YES;
}
return NO;
}
Expand Down